Fix value-based comparison under Py3k.

zopefoundation · May 25, 2013 · e994712 · mgedmin · May 27, 2013 · e994712
1 parent 912b0a2
commit e994712
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/BTrees/objectvaluemacros.h b/BTrees/objectvaluemacros.h
@@ -2,7 +2,7 @@
 
 #define VALUE_TYPE PyObject *
 #define VALUE_TYPE_IS_PYOBJECT
-#define TEST_VALUE(VALUE, TARGET) COMPARE((VALUE),(TARGET))
+#define TEST_VALUE(VALUE, TARGET) (COMPARE((VALUE),(TARGET)))
 #define DECLARE_VALUE(NAME) VALUE_TYPE NAME
 #define INCREF_VALUE(k) Py_INCREF(k)
 #define DECREF_VALUE(k) Py_DECREF(k)

diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,6 +4,9 @@
 Unreleased
 ----------
 
+- Fix value-based comparison for objects under Py3k:  addresses invalid
+  merges of ``[OLI]OBTrees/OBuckets``.
+
 - Ensure that pure-Python implementation of ``OOBTree.byValue`` matches
   semantics (reversed-sort) of C implementation.