Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds python 3.8 on macos to the travis build. #119

Merged
merged 1 commit into from
Jan 13, 2020
Merged

adds python 3.8 on macos to the travis build. #119

merged 1 commit into from
Jan 13, 2020

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jan 12, 2020

This should allow for making macos wheels for py3.8.

@fgregg fgregg requested a review from mgedmin January 12, 2020 03:11
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, excellent!

@fgregg fgregg merged commit e0a9880 into master Jan 13, 2020
@fgregg
Copy link
Contributor Author

fgregg commented Jan 13, 2020

thanks @mgedmin, could you trigger a pypi build. we shouldn't need to cut a new release.

@mgedmin
Copy link
Member

mgedmin commented Jan 13, 2020

thanks @mgedmin, could you trigger a pypi build. we shouldn't need to cut a new release.

You should be able to do it too. The procedure for building wheels is

  • create new temporary git branch based on the release tag you want
  • cherry-pick the .travis.yml (or appveyor) changes you want
  • comment out all the jobs you don't want (builds for OSes/versions that already have wheels), basically just leave the one job you want
  • comment out the condition that only git tags run this pypi upload job
  • push the temporary git branch
  • wait for Travis CI to build and upload the wheel
  • delete the temporary git branch

(you can see how cutting a new release is often easier)

@fgregg
Copy link
Contributor Author

fgregg commented Jan 13, 2020

thanks! will do.

@fgregg
Copy link
Contributor Author

fgregg commented Jan 16, 2020

Hi @mgedmin, I flubbed these instructions a bit by not starting by basing off the release tag, so I pushed a prelease version to pypi. https://pypi.org/project/BTrees/4.6.2.dev0/

Many apologies, let me know how you would like me to proceed.

@mgedmin
Copy link
Member

mgedmin commented Jan 16, 2020

Well, the good news is prereleases on PyPI are harmless, since pip install will ignore them.

I've deleted the bad release anyway.

@fgregg
Copy link
Contributor Author

fgregg commented Jan 16, 2020

really sorry about this. I think I'm going to just wait until your next release.

@mgedmin
Copy link
Member

mgedmin commented Jan 16, 2020

I seriously doubt that anyone else even noticed a single MacOS-only binary wheel of a prerelease version that was available for a few hours only. And hey, a valuable learning experience!

(I wish Travis CI would allow jobs to generate and make available for downloading artifacts, like Appveyor does. Then one could build the wheels, test them, then upload them manually.)

@icemac icemac deleted the travis_3.8 branch January 17, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants