-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds python 3.8 on macos to the travis build. #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, excellent!
thanks @mgedmin, could you trigger a pypi build. we shouldn't need to cut a new release. |
You should be able to do it too. The procedure for building wheels is
(you can see how cutting a new release is often easier) |
thanks! will do. |
Hi @mgedmin, I flubbed these instructions a bit by not starting by basing off the release tag, so I pushed a prelease version to pypi. https://pypi.org/project/BTrees/4.6.2.dev0/ Many apologies, let me know how you would like me to proceed. |
Well, the good news is prereleases on PyPI are harmless, since pip install will ignore them. I've deleted the bad release anyway. |
really sorry about this. I think I'm going to just wait until your next release. |
I seriously doubt that anyone else even noticed a single MacOS-only binary wheel of a prerelease version that was available for a few hours only. And hey, a valuable learning experience! (I wish Travis CI would allow jobs to generate and make available for downloading artifacts, like Appveyor does. Then one could build the wheels, test them, then upload them manually.) |
This should allow for making macos wheels for py3.8.