-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial port to GitHub Actions #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As used in persistent and zope.interface. Unlike those, enable coverage conditionally, it's far too slow to always run (builds go from a minute to 6 minutes). Adds Python 3.9 and aarch64 wheels.
Otherwise we get 'no source' errors. https://github.com/zopefoundation/BTrees/runs/2201332213?check_suite_focus=true#step:13:26
Borrow a trick from gevent and set CFLAGS=-O1. List the supported Python variants in order so we can know what we're building and what's left to do; this makes following the logs easier.
So we were only getting the pure-Python version. See #154
icemac
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay for me from reading the diff.
Thanks for taking a look. |
Could someone with access to the |
Merged
Secret added. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As used in persistent and zope.interface.
Unlike those, enable coverage conditionally, it's far too slow to always run (builds go from a minute to 6 minutes).
Adds Python 3.9 and aarch64 wheels.