-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appveyor script #30
Appveyor script #30
Conversation
- echo password=%password% >> %USERPROFILE%\\.pypirc | ||
- set HOME=%USERPROFILE% | ||
- pip install wheel twine | ||
- ps: if($env:APPVEYOR_REPO_TAG -eq $TRUE) { python -W ignore setup.py && twine upload dist/* } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that python setup.py
be python setup.py bdist_wheel bdist_egg
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some body is already building window eggs for BTree? https://pypi.python.org/pypi/BTrees
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some body is already building window wheels for BTree?
That would be the zope.wineggbuilder
deployment, which is on the same hard-to-maintain machine as the zope.winbot
deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note how existing wineggbuilder uploads lack support for Python 3.3, 3.4 and 3.5 (and also for wheels).
We'll probably want to disable wineggbuilder for BTrees as soon as Appveyor starts working. That can be done by specifying maxVersion in https://github.com/zopefoundation/zope.wineggbuilder/blob/master/rackspace.ini#L274
BTW the only other ZopeFoundation project that uses appveyor that I know of is zope.interface: (It doesn't build wheels or upload them to PyPI -- at the moment.) The approach to Python versions seems quite different than here. Any reason for that? Can we simplify the zope.interface appveyor.yml? |
@@ -35,6 +36,6 @@ deploy_script: | |||
- echo password=%password% >> %USERPROFILE%\\.pypirc | |||
- set HOME=%USERPROFILE% | |||
- pip install wheel twine | |||
- ps: if($env:APPVEYOR_REPO_TAG -eq $TRUE) { python -W ignore setup.py && twine upload dist/* } | |||
- ps: if($env:APPVEYOR_REPO_TAG -eq $TRUE) { python -W ignore setup.py bdist_wheel bdist_egg && twine upload dist/* } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd completely forgotten that the old wineggbuilder used to upload both .exe and .egg files. Question for the audience: do we still need .exe installers?
My gut feeling is that people who still use zc.buildout will need .egg, and people who have migrated to pip will need .whl, but probably nobody needs .exe. Unless there are still people who install stuff manually by downloading installers from PyPI and running them?
Do you need anything else from me right now? |
Here's the encrypted zope.wheelbuilder password for Appveyor: RtpeKCle25vCixaUcJBu6Q== Here's the appveyor project page, under my personal appveyor account: https://ci.appveyor.com/project/mgedmin/btrees How does ZopeFoundation intend to manage appveyor accounts? |
I don't know how to ask AppVeyor to try-build this PR. I expect it will try a build when you push a commit to update the encrypted secret. |
Hi @mgedmin it looks like you have to do a kind of workaround for this http://help.appveyor.com/discussions/problems/2209-node-grunt-build-specify-a-project-or-solution-file-the-directory-does-not-contain-a-project-or-solution-file#comment_36945393 |
Why do you say that? The current appveyor failures are expected: none of the branches being built had an Now we're waiting for you to push any commit (e.g. updating the encrypted secret) to this branch so Appveyor gets a chance. |
Woops! Sorry it's building. Appveyor disables deploys in Pull Requests, so that's why that section is no showing up. |
Okay, I think this good to merge. The failing build is due to real failures of the tests. #32 |
Let's get the broken test fixed (or at least skip it on 64-bit windows with |
testing the sys.maxsize here, since this is the only PR with appveyor tests |
Heh, @mgedmin just turned off appveyor for branches w/o |
@tseaver sure, we can get it working in this branch. |
Okay the sys.maxsize idea won't work because on windows python 3, x64
|
For reference:
and the code raising the OverflowError is not in BTrees C code: when it detects a too-large / too-small value, it raises |
This appveyor script will
You will need to