Stop installing terryfy. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
requested changes
Oct 23, 2018
MANIFEST.in
Outdated
| @@ -1,3 +1,4 @@ | |||
| pruny terryfy | |||
There was a problem hiding this comment.
Typo -- I think you meant prune.
There was a problem hiding this comment.
Yikes, how'd that happen. Thanks.
There was a problem hiding this comment.
python setup.py sdist outputs a warning:
reading manifest template 'MANIFEST.in'
warning: manifest_maker: MANIFEST.in, line 1: unknown action 'pruny'
But check-manifest -v does not.
There was a problem hiding this comment.
Yeah, it would be good if check-manifest would syntactic validity as well -> mgedmin/check-manifest#85
mgedmin
reviewed
Oct 23, 2018
| packages=find_packages(), | ||
| # Make sure we don't get 'terryfy' included in wheels | ||
| # created on macOS CI | ||
| packages=find_packages(include=("BTrees",)), |
There was a problem hiding this comment.
This is BTW a yet another reason to prefer a src subdirectory at the project root ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.