Cast int to float in compare methods. #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
DateTime(int)
behaviour is same asDateTime(float)
, we expectequalTo(int)
behaviour same asequalTo(float)
and same for other compare methods as well.FYI, the coverate rate becomes a bit worse with this change but it is just because
src/DateTime/DateTime.py
has less number of lines, i.e. the number of non-covered lines does not increase.