Skip to content

Commit

Permalink
Implemented reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
sallner committed Oct 5, 2018
1 parent 9925d0b commit 24b994f
Showing 1 changed file with 18 additions and 11 deletions.
29 changes: 18 additions & 11 deletions src/DocumentTemplate/tests/test_DT_In.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,19 @@ def test_sort_sequence(self):
class DT_In_Tests(unittest.TestCase):
"""Functional testing ..DT_In.InClass."""

def _get_doc_class(self):
def assertRaisesRegex(self, *args, **kw):
try:
# available from Python 3.2
return unittest.TestCase.assertRaisesRegex(self, *args, **kw)
except AttributeError:
# only available till Python 3.7
return unittest.TestCase.assertRaisesRegexp(self, *args, **kw)

@property
def doc_class(self):
from DocumentTemplate.DT_HTML import HTML
return HTML

doc_class = property(_get_doc_class,)

def test_DT_In__InClass____init__1(self):
"""It only allows alphanumeric + `_` characters in prefix."""
sequence = ['a', 'b', 'c']
Expand All @@ -61,7 +68,7 @@ def test_DT_In__InClass____init__1(self):
'Item <dtml-var sequence-number>: '
'<dtml-var sequence-item>'
'</dtml-in>')
with self.assertRaisesRegexp(ParseError, '^prefix is not a simple '):
with self.assertRaisesRegex(ParseError, '^prefix is not a simple '):
html(seq=sequence)

def test_DT_In__InClass____init__2(self):
Expand All @@ -86,7 +93,7 @@ def test_DT_In__InClass____init__2(self):
'<dtml-else>'
'Still no items available'
'</dtml-in>')
with self.assertRaisesRegexp(ParseError, '^too many else blocks'):
with self.assertRaisesRegex(ParseError, '^too many else blocks'):
html(seq=[])

def test_DT_In__InClass____init__3(self):
Expand All @@ -101,7 +108,7 @@ def test_DT_In__InClass____init__3(self):
for arg in batch_args:
html = self.doc_class(template.format(arg=arg))
error_msg = 'The {arg} attribute was used'.format(arg=arg)
with self.assertRaisesRegexp(ParseError, error_msg):
with self.assertRaisesRegex(ParseError, error_msg):
html(seq=['a', 'b'])

def test_DT_In__InClass____init__4(self):
Expand All @@ -111,7 +118,7 @@ def test_DT_In__InClass____init__4(self):
'Item <dtml-var sequence-number>: '
'<dtml-var sequence-item>'
'</dtml-in>')
with self.assertRaisesRegexp(ValueError, 'Strings are not allowed as'):
with self.assertRaisesRegex(ValueError, 'Strings are not allowed as'):
html(seq="Foo")

def test_DT_In__InClass____init__5(self):
Expand All @@ -135,7 +142,7 @@ def test_DT_In__InClass__renderwob__01(self):
'Item <dtml-var sequence-number>: '
'<dtml-var sequence-item>'
'</dtml-in>')
with self.assertRaisesRegexp(ValueError, 'Strings are not allowed as'):
with self.assertRaisesRegex(ValueError, 'Strings are not allowed as'):
html(seq="Foo")

def test_DT_In__InClass__renderwob__02(self):
Expand Down Expand Up @@ -306,7 +313,7 @@ def test_DT_In__InClass__renderwb__01(self):
'Item <dtml-var sequence-number>: '
'<dtml-var sequence-item>'
'</dtml-in>')
with self.assertRaisesRegexp(ValueError, 'Strings are not allowed as'):
with self.assertRaisesRegex(ValueError, 'Strings are not allowed as'):
html(seq="Foo")

def test_DT_In__InClass__renderwb__02(self):
Expand Down Expand Up @@ -409,7 +416,7 @@ def test_DT_In__make_sortfunction__1(self):
'<dtml-var sequence-item>'
'</dtml-in>')
error_msg = 'sort option must contain no more than 2 slashes'
with self.assertRaisesRegexp(SyntaxError, error_msg):
with self.assertRaisesRegex(SyntaxError, error_msg):
html(seq=seq)

def test_DT_In__make_sortfunction__2(self):
Expand All @@ -421,7 +428,7 @@ def test_DT_In__make_sortfunction__2(self):
'<dtml-var sequence-item>'
'</dtml-in>')
error_msg = 'sort oder must be either ASC or DESC'
with self.assertRaisesRegexp(SyntaxError, error_msg):
with self.assertRaisesRegex(SyntaxError, error_msg):
html(seq=seq)

def test_DT_In__make_sortfunction__3(self):
Expand Down

0 comments on commit 24b994f

Please sign in to comment.