Avoid ResourceWarnings about unclosed file descriptors.

zopefoundation · May 14, 2017 · 34db5b9 · 34db5b9
1 parent 4cc5e5c
commit 34db5b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/DocumentTemplate/DT_String.py b/src/DocumentTemplate/DT_String.py
@@ -566,7 +566,9 @@ def read_raw(self):
             print('file not found: %s' % self.raw)
 
         if self.raw:
-            return open(self.raw, 'r').read()
+            with open(self.raw, 'r') as fd:
+                raw = fd.read()
+            return raw
         return ''
 
 

diff --git a/src/DocumentTemplate/tests/testDTML.py b/src/DocumentTemplate/tests/testDTML.py
@@ -562,9 +562,8 @@ def read_file(name):
     import os
     from DocumentTemplate import tests
     here = tests.__path__[0]
-    f = open(os.path.join(here, name), 'r')
-    res = f.read()
-    f.close()
+    with open(os.path.join(here, name), 'r') as fd:
+        res = fd.read()
     return res