Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rendering encoding configurable #44

Merged
merged 8 commits into from
Apr 25, 2019
Merged

Make rendering encoding configurable #44

merged 8 commits into from
Apr 25, 2019

Commits on Apr 22, 2019

  1. Use a module global for the encoding used to decode strings into unicode

    @malthe @dataflake
    malthe authored and dataflake committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    1042151 View commit details
    Browse the repository at this point in the history

  2. Add optional keyword argument 'encoding'

    @malthe @dataflake
    malthe authored and dataflake committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    0f10935 View commit details
    Browse the repository at this point in the history

  3. - fix missing encoding arguments in constructors

    @dataflake
    dataflake committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    c2b0754 View commit details
    Browse the repository at this point in the history

  4. - address Michael's change requests from the original PR

    @dataflake
    dataflake committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    f35e1f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. - fix up all tests

    @dataflake
    dataflake committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    58625d9 View commit details
    Browse the repository at this point in the history

  2. - flake8

    @dataflake
    dataflake committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    6552bb3 View commit details
    Browse the repository at this point in the history

  3. - actually use the passed-in encoding

    @dataflake
    dataflake committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    ad2915f View commit details
    Browse the repository at this point in the history

  4. - be more explicit when passing the encoding parameter

    @dataflake
    dataflake committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    44a1c60 View commit details
    Browse the repository at this point in the history