use C3 MRO if called for via envvar EXTENSIONCLASS_C3_MRO
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added testing the C3 variant to |
This is not correct (yet): The GHA configuration is currently ignored by the |
This reverts commit ab320d3.
…on/ExtensionClass into experimental_C3_MRO
Currently without `meta/config` support.
|
But I added the necessary configuration directly to the GHA config. |
…on/ExtensionClass into experimental_C3_MRO
…on/ExtensionClass into experimental_C3_MRO
|
The experiment was abandoned in zopefoundation/Zope#982. Keeping the changes here for the record. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets the envvar
EXTENSIONCLASS_C3_MROcontrol whetherExtensionClassuses Python's C3 method resolution order or continues to use the old classic one (that from Python's "old style classes"). If defined the value must be an integer and is used as boolean.During the test (using the
Zopetests) I hit several examples which gave me the impression that the C3 MRO is far less intuitive than the classic one. In easy cases, the problem manifested itself at class definition time (TypeError: cannot determine a consistent resolution error); however, sometimes, it manifested itself in subtle behavior change. It took me considerable effort to rearrange the class hierarchy in those cases. I expect that other applications, too, would require considerable class hierarchy restructuring to use the C3 MRO.