Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Python3 port of the C-Extension #9
I found a regression in ExtensionClass (python version and also my C version) while working on the C-Extension of Acquisition
The old C code of ExtensionClass changed an attribute error into the following:
The python version (+ my ported C version) does the following:
See, the error messages contains the typename of an object.
The python version of Acquisition struggled also with the changed behaviour of ExtensionClass.
@jamadden any comments on this? Since you wrote the python version of Acquisition.
I don't particularly care. The only reason the code in Acquisition you pointed to is there is because of doctests; I'm not particularly a fan of doctests or relying on exact exception messages in general, but I didn't want to break anything or create too large of a PR.
Personally, I'd rather see the more informative error messages raised everywhere (although in Acquisition's case, that could be slightly misleading).
added a commit
this pull request
Jan 18, 2017
I've reviewed this to the best of my ability and found no issues.
I've squashed and merged this manually in f6ef36a. In subsequent commits I've extended the tox test list of cover all combinations of pure/non-pure environments and all Python versions addressing icemac's comment.