Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several DeprecationWarnings during unit tests #113

Merged
merged 1 commit into from Apr 24, 2021
Merged

Fix several DeprecationWarnings during unit tests #113

merged 1 commit into from Apr 24, 2021
+35 −18

Conversation

dataflake
Copy link
Member

Fixes #112

@dataflake dataflake self-assigned this Apr 23, 2021
@dataflake dataflake added this to In progress in Sprint 2021-04-23 via automation Apr 23, 2021
jugmac00
jugmac00 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no domain knowledge, but the changes look reasonable!

LGTM

@dataflake dataflake merged commit 81b45cc into master Apr 24, 2021
Sprint 2021-04-23 automation moved this from In progress to Done Apr 24, 2021
@dataflake dataflake deleted the dataflake/issue_112 branch April 24, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugmac00 jugmac00 jugmac00 approved these changes

@icemac icemac Awaiting requested review from icemac

Assignees

@dataflake dataflake

Labels
enhancement
Projects
No open projects
Sprint 2021-04-23
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning
2 participants
@dataflake @jugmac00