Avoid write-on-read when initializing MemberAdapter #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
requested changes
Oct 16, 2017
|
@tseaver tests added |
tseaver
approved these changes
Oct 17, 2017
mauritsvanrees
requested changes
Oct 17, 2017
Products/CMFCore/MemberDataTool.py
Outdated
|
|
||
| @security.private | ||
| def notifyModified(self): | ||
| # Links self to parent for full persistence. | ||
| self._tool._members[id] = self._md |
There was a problem hiding this comment.
id is not defined here. It triggers no warnings because id is a builtin.
|
Good catch, @mauritsvanrees. That made me look at what registerMemberData does and realize that even if the broken line I added did what I intended, it would be redundant. |
mauritsvanrees
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids writing a MemberData object to the database when MemberAdapter is being looked up for reads only. (The change is needed to avoid triggering CSRF protection errors in Plone tests.)