Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare the proper dependency. #55

Merged
merged 1 commit into from Nov 20, 2018
Merged

Declare the proper dependency. #55

merged 1 commit into from Nov 20, 2018

Conversation

sallner
Copy link
Member

@sallner sallner commented Nov 20, 2018

The content of Products.ZCTextIndex moved to Products.ZCatalog which was a non-declared dependency any way.

dataflake
dataflake approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dataflake dataflake merged commit 11d95c4 into master Nov 20, 2018
@dataflake dataflake deleted the zcatalog-dependency branch November 20, 2018 12:56
icemac
icemac reviewed Nov 21, 2018
View reviewed changes
setup.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac left review comments

@dataflake dataflake dataflake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sallner @icemac @dataflake