Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for Python 3.5 and 3.6. #5

Closed
wants to merge 3 commits into from
Closed

[WIP] Add support for Python 3.5 and 3.6. #5

wants to merge 3 commits into from

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 21, 2018

There are currently two tests failing. It would be nice if someone could look into them as I do not use this package at all.

@icemac
Copy link
Member Author

icemac commented Apr 17, 2018

I investigated the failures an found that the index contains a key with the value '' (aka empty string). It points to the DummyContent object. Something seems to be wrong during indexing it for the first time – when it does not yet have an cmf_uid attribute – turning the AttributeError into an empty string.

@icemac
Copy link
Member Author

icemac commented Apr 17, 2018

@dataflake Do you might know what's causing this behaviour?

@dataflake
Copy link
Member

I'm afraid I don't have any knowledge here. Never used CMFUid.

@ale-rt
Copy link
Member

ale-rt commented Apr 22, 2018

See #7 @icemac

@icemac icemac closed this in #7 Jul 5, 2018
@icemac icemac deleted the py3 branch July 5, 2018 07:04
@icemac
Copy link
Member Author

icemac commented Jul 5, 2018

@ale-rt Thank you for fixing this in #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants