-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-existing dependency-profiles cause multiple errors #68
Comments
Closing this because I don't have more time left to spend on this. Thanks anyways! |
Made a sketch for failing when rising the instance, if a profile-name has no registration in a zcml-file: @tseaver As you are Zope-pioneer, I'd appreciate a lot your opinion, whether hooking into @sunew pinging you in case you're still on debugging the related issue in the Plone-repo. |
@ida thanks - I had to take look at some other issues, but will return to this one during the week. |
Refs: #64, plone/Products.CMFPlone#2228.
The multiple errors still occur, I think the culprit lies in
getProfileDependenciesChain
, because it is calling itself recursively:Products.GenericSetup/Products/GenericSetup/tool.py
Line 1331 in 3ca5ee7
And the try/except-block in
_runImportStepsFromContext
of where it's called initially, is masking this:Products.GenericSetup/Products/GenericSetup/tool.py
Line 1386 in 3ca5ee7
Probably because the first try succeeds and later an exception occurs from a recursive-call.
So, I tried raising an error explicitly in
getProfileDependenciesChain
, but that also doesn't stop the execution of further code.The only solution I came up with, is to return None in
getDependenciesForProfile
for symbolizing dependencies are broken, like it was sugested in #64:dd11374
That will cause the interpreter to raise a "not-iterable"-error in
getProfileDependenciesChain
and fail hard, as wished.@tseaver, @icemac, @sunew, if you think this is feasible, I'd like to provide another PR.
The text was updated successfully, but these errors were encountered: