Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12. #63

Merged
merged 2 commits into from
May 24, 2024

Conversation

perrinjerome
Copy link
Contributor

No description provided.

@perrinjerome perrinjerome force-pushed the config-with-zope-product-template-4ff54999 branch from 15fd577 to b57372f Compare May 24, 2024 06:01
@perrinjerome
Copy link
Contributor Author

@icemac I ran bin/python config-package.py ../../Products.PythonScripts/ --type zope-product

py312 fails on CI, because of buildout/buildout#648 . My understanding is that this error is potentially everywhere in buildout based packages, I don't understand why only 3.12 is affected, but this looks like an old compatible version of setuptools was already installed for other python versions but not for python3.12

in the logs of py311 we can see

py311: freeze> python -m pip freeze --all
py311: pip==24.0,setuptools==69.5.1,wheel==0.43.0,zc.buildout==3.0.1

this is using a compatible old setuptools and test passed for 3.11.

but in the logs of py312

py312: freeze> python -m pip freeze --all
py312: pip==23.1.2,setuptools==70.0.0,wheel==0.43.0,zc.buildout==3.0.1

using incompatible new setuptools and there's this error.

I don't really need this pull request now, I just noticed that there was no python3.12 so I tried to enable it.

All this makes me wonder if it makes sense to pin setuptools < 70 in all zopefoundation repositories for now ?

@icemac
Copy link
Member

icemac commented May 24, 2024

Hi @perrinjerome zope-product was not yet pinned to setuptools < 69. I just added it. For details see zopefoundation/meta#243 and buildout/buildout#648

@icemac
Copy link
Member

icemac commented May 24, 2024

So you could pull in the changes in meta and run config again. This time please run it with the --branch option pointing to this branch otherwise it will create a new one.

@perrinjerome perrinjerome force-pushed the config-with-zope-product-template-4ff54999 branch from b57372f to 0dd1ab5 Compare May 24, 2024 09:26
@perrinjerome perrinjerome marked this pull request as ready for review May 24, 2024 09:30
@perrinjerome
Copy link
Contributor Author

Thank you @icemac I did not notice that this was already (partially) supported. It should be OK now

@perrinjerome perrinjerome merged commit 854d1cc into master May 24, 2024
14 checks passed
@perrinjerome perrinjerome deleted the config-with-zope-product-template-4ff54999 branch May 24, 2024 14:09
@perrinjerome
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants