Update configuration for version 5 of isort
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove deprecated configuration options - remove duplicate isort check via flake8 - fix sort order of imports modified: CHANGES.rst modified: setup.cfg modified: src/Products/SiteErrorLog/SiteErrorLog.py modified: src/Products/SiteErrorLog/tests/testInitialization.py modified: tox.ini
dataflake
approved these changes
Jul 16, 2020
jugmac00
commented
Jul 16, 2020
| @@ -3,7 +3,8 @@ language: python | |||
| matrix: | |||
| include: | |||
| - python: "3.6" | |||
| env: TOXENV=flake8 | |||
| env: TOXENV=lint | |||
| after_success: | |||
| - python: "2.7" | |||
There was a problem hiding this comment.
Could you give me a hint about the reasoning?
There was a problem hiding this comment.
If you look at what after_success does it should be clear that it doesn't make sense for the linting step. The linting step produces no coverage data and coveralls will misinterpret that as "zero coverage".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: CHANGES.rst
modified: setup.cfg
modified: src/Products/SiteErrorLog/SiteErrorLog.py
modified: src/Products/SiteErrorLog/tests/testInitialization.py
modified: tox.ini