Skip to content
This repository has been archived by the owner on May 13, 2020. It is now read-only.

Commit

Permalink
Merged efge-death-to-dtml-var-branch into HEAD:
Browse files Browse the repository at this point in the history
Removed most <dtml-var> to replace them with &dtml-foo;.
This corrects a number of potential XSS holes, and simplifies
auditability of the remaining legitimate <dtml-var>.
  • Loading branch information
Florent Guillaume committed Dec 22, 2002
1 parent 8431db6 commit 3af08f2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion dtml/addLexicon.dtml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
</select>
<dtml-else>
<input type="checkbox" name="elements.name:records"
value="<dtml-var expr="elements[0]">" checked />
value="<dtml-var expr="elements[0]" html_quote>" checked />
</dtml-if>
</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion dtml/addZCTextIndex.dtml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ from the most relevant to the least relevant.
<select name="extra.lexicon_id:record">
</dtml-if>
<option value="&dtml-id;">
&dtml-id; <dtml-var name="title" fmt="(%s)" null>
&dtml-id; <dtml-var name="title" fmt="(%s)" null html_quote>
</option>
<dtml-if sequence-end>
</select>
Expand Down
8 changes: 4 additions & 4 deletions dtml/manageZCTextIndex.dtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@

<p class="form-help">
Name of attribute indexed:
<em><dtml-var getFieldName></em>
<em>&dtml-getFieldName;</em>
</p>
<p class="form-help">
Index type:
<em><dtml-var getIndexType></em>
<em>&dtml-getIndexType;</em>
</p>
<p class="form-help">
ZCTextIndex Lexicon used:
<dtml-if getLexiconURL>
<a href="<dtml-var getLexiconURL>/manage_main"
><dtml-var getLexiconURL></a>
<a href="&dtml.url_quote-getLexiconURL;/manage_main"
>&dtml-getLexiconURL;</a>
<dtml-else>
<em>(Lexicon Not Found)</em>
</dtml-if>
Expand Down

0 comments on commit 3af08f2

Please sign in to comment.