use assertRaises instead of try/except for expected KeyError

zopefoundation · May 8, 2020 · 419d3be · 419d3be
1 parent 341d69c
commit 419d3be
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/Products/PluginIndexes/FieldIndex/tests.py b/src/Products/PluginIndexes/FieldIndex/tests.py
@@ -224,13 +224,8 @@ def testReindexNone(self):
         d._foo = None
         self._index.index_object(2, d)
         self._checkApply({'foo': 'abc'}, [])
-        try:
-            should_not_be = self._index.keyForDocument(2)
-        except KeyError:
-            # As expected, that attribute is None
-            pass
-        else:
-            raise ValueError(repr(should_not_be))
+        with self.assertRaises(KeyError):
+            self._index.keyForDocument(2)
 
     def testReindex(self):
         self._populateIndex()