Skip to content

Commit

Permalink
Fix logging issue in KeywordIndex.
Browse files Browse the repository at this point in the history
The `debug` method of a logger does not accept an `error` keyword, see
https://docs.python.org/3.6/library/logging.html#logging.Logger.debug
resp.
https://docs.python.org/2/library/logging.html#logging.Logger.debug

This issue did not get noticed because the with the default log level in tests
this log message is discarded.
  • Loading branch information
Michael Howitz committed Mar 6, 2018
1 parent 3ebd8db commit ed0d018
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Changelog
on `searchResults` returning all brains for empty queries before
version 4.0a2.

- Fix logging issue in KeywordIndex.

4.0.1 (2017-10-10)
------------------

Expand Down
2 changes: 1 addition & 1 deletion src/Products/PluginIndexes/KeywordIndex/KeywordIndex.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def unindex_object(self, documentId):
LOG.debug('%s: Attempt to unindex nonexistent '
'document with id %s' %
(self.__class__.__name__, documentId),
error=sys.exc_info())
exc_info=True)

manage = manage_main = DTMLFile('dtml/manageKeywordIndex', globals())
manage_main._setName('manage_main')
Expand Down

0 comments on commit ed0d018

Please sign in to comment.