Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 100 #103

Merged
merged 4 commits into from
May 8, 2020
Merged

Fix 100 #103

merged 4 commits into from
May 8, 2020

Conversation

ewohnlich
Copy link
Contributor

@ewohnlich ewohnlich commented May 6, 2020

Fix case where index value is changed to None after previously being indexed. Values of type None are still not allowed, but it should now also unindex a previous value if one existed.

Copy link
Contributor

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement.

In your test, maybe, you could use self.assertRaises (as context manager -- i.e. with self.assertReaises(KeyError)) instead of the tedious try .. except else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants