fixes entry insert when index is reverted at the same time #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, i reproduce the issue into legacy code tests. those tests pass using my patch or using FieldIndex, and don't pass using not patched BooleanIndex |
inverted the index value
when an existing content was reindexed with an opposite value. Fixes LP #1236354.
|
Thank you Actually, it was really more complicated, problem occured when when index inversion occured insertForwardEntry was not the problem, but the fact that invert_index method uses the value of unindex length that was updated after. actually we have to update unindex before we may invert the index |
|
Can you review and merge if possible ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this commit fixes a critical problem i encountered. The value inserted at the moment when the index is inverted was wrong (the value was set as false instead of true at the moment index value was inverted from false to true)
do you have an opinion about this ?
the problem is that i am not 100% sure that this commit is good. Obviously it won't introduce a regression (this looks more robust) but i coul'nt write a test to prove the problem i encountered can be reproduced.