Query with invalid paramter should raise an error

[andbag]

Parameters can be used for a query that are not supported by the indexes. The user does not receive a feedback about the invalid used parameters. Results of a query could therefore misinterpreted. This behavior has already been identified

Products.ZCatalog/src/Products/PluginIndexes/FieldIndex/tests.py

Lines 258 to 259 in dd30d44

	# Make sure that range tests with incompatible paramters
	# don't return empty sets.

but the strategy is simply to ignore the invalid parameter. I therefore suggest that instead of skipping invalid parameters, an error should be raised.

[icemac]

I think this is a good idea. As it changes the behaviour I'd suggest to bump the version to the next major one (in CHANGES.rst and setup.py) and add a description of the issue and the solution to the change log.

[d-maurer]

Because the error comes from the user, I would prefer ValueError over RuntimeError.

Putting the test into a new options property causes code duplication: the access logic is now both in __init__ as well as options. I suggest to put the test into the set method - and make options a passive attribute (rather than an active property).

Line 109 could be slightly simpified: = value instead of = value.lower() (value has been lowered a few lines before).

[d-maurer]

I am happy.

[andbag]

@icemac I have created an entry in the change log. I don't have any practice in code management for the community. Therefore I ask you to do the next steps as soon as the right time is reached.

[icemac]

@andbag Thank you for fixing this issue. Should I cut a release now or are you planning other fixes which should go into the next release?

[andbag]

@icemac Thank you for the merge, it would be nice if the PR #68 would also be included in the next release.