Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for not queries in the UUIDIndex #99

Merged
merged 2 commits into from Apr 20, 2020
Merged

Conversation

sneridagh
Copy link
Contributor

No description provided.

@sneridagh
Copy link
Contributor Author

See #98

@sneridagh sneridagh requested a review from ale-rt April 17, 2020 13:22
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no good idea what's the use case is, but well, why not and it LGTM.

@tisto
Copy link

tisto commented Apr 18, 2020

@jensens @pbauer what's the process for this? Can we merge this PR now? Who is responsible for making releases for Zope?

@jugmac00
Copy link
Member

Afaik there are no written rules, ie no real contributor documentation, which would be pretty good idea to create. Maybe at the next sprint, @icemac ?

Usually, there are these prerequisites:

  • the committer needs a signed contributors agreement and creates a pr
  • another committer needs to accept the pull request
  • the creator of the pr merges the pr

That's the bare minimum.

Usually, for non trivial changes the reviewer should have a good knowledge of the package.

I think @d-maurer is the one with really deep knowledge about the ZCatalog, at least I would ask him for changes in the ZCatalog.

Responsible for Releases
There are no fixed releasers in the Zope community. You usually have to lookup the releaser of a package on PyPi and ask them.
https://pypi.org/project/Products.ZCatalog/

@hannosch is pretty much inactive, @tseaver answers occasional questions, but the other two are very active.

@tisto
Copy link

tisto commented Apr 19, 2020

Thanks for the heads up @jugmac00! @sneridagh has signed the contributor agreement and we have three PR reviews. I guess we are good to merge then.

@dataflake @icemac would it be possible to get a release that includes this merge?

@icemac icemac merged commit 49e36f8 into master Apr 20, 2020
@icemac icemac deleted the uidindexnotsupport branch April 20, 2020 06:16
@icemac
Copy link
Member

icemac commented Apr 20, 2020

I just released https://pypi.org/project/Products.ZCatalog/5.1/.

@sneridagh
Copy link
Contributor Author

Thanks a lot @icemac !

@tisto
Copy link

tisto commented Apr 20, 2020

Awesome! Thank you @icemac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants