New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for not
queries in the UUIDIndex
#99
Conversation
See #98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no good idea what's the use case is, but well, why not and it LGTM.
Afaik there are no written rules, ie no real contributor documentation, which would be pretty good idea to create. Maybe at the next sprint, @icemac ? Usually, there are these prerequisites:
That's the bare minimum. Usually, for non trivial changes the reviewer should have a good knowledge of the package. I think @d-maurer is the one with really deep knowledge about the ZCatalog, at least I would ask him for changes in the ZCatalog. Responsible for Releases @hannosch is pretty much inactive, @tseaver answers occasional questions, but the other two are very active. |
Thanks for the heads up @jugmac00! @sneridagh has signed the contributor agreement and we have three PR reviews. I guess we are good to merge then. @dataflake @icemac would it be possible to get a release that includes this merge? |
I just released https://pypi.org/project/Products.ZCatalog/5.1/. |
Thanks a lot @icemac ! |
Awesome! Thank you @icemac! |
No description provided.