Add support for Python 3.12 and ZODB 6. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To claim Python 3.12 support please run the config tool to update all places that need updating: https://github.com/zopefoundation/meta/tree/master/config |
dataflake
approved these changes
Nov 24, 2023
|
Version 4.1 is now live |
|
@dataflake thank you, and sorry for not doing it myself. It was on my stack of things to do.... |
icemac
reviewed
Nov 27, 2023
|
|
||
| from AccessControl import ClassSecurityInfo | ||
| from AccessControl.class_init import InitializeClass | ||
| from Acquisition import Implicit | ||
| from Acquisition import aq_base | ||
| from OFS.SimpleItem import SimpleItem | ||
| from Persistence import Persistent | ||
| from ZODB._compat import BytesIO | ||
| from ZODB._compat import Pickler |
There was a problem hiding this comment.
This will probably break with the next ZODB release. Importing from modules starting with an underscore can be a source of trouble. But we'll see and fix it later.
There was a problem hiding this comment.
This underscores the need for using tools like zope.deprecation more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out Plone 6.1 on Python 3.12 with ZODB 6 and ZEO 6 (both source checkouts) I had to apply this fix to make Products.ZopeVersionControl work together with this stack.
It's basically the same as
ZODB._compatwas doing anyways for Python 3, see:zopefoundation/ZODB@6f88781#diff-d3f727ac8d95d754aa9b86cbba3715c589e7d19735265064e9cedb3ff27f3517L127