fix invalid source code input and test it

src/RestrictedPython/compile.py

@@ -1,7 +1,9 @@
 from collections import namedtuple
+from RestrictedPython._compat import IS_PY2
 from RestrictedPython.transformer import RestrictingNodeTransformer
 
 import ast
+import warnings
 
 
 CompileResult = namedtuple(
@@ -25,13 +27,14 @@ def _compile_restricted_mode(
         # Unrestricted Source Checks
         byte_code = compile(source, filename, mode=mode, flags=flags,
                             dont_inherit=dont_inherit)
-    # TODO: Should be an elif check if policy is subclass of
-    # RestrictionNodeTransformer any other object passed in as policy might
-    # throw an error or is a NodeVisitor subclass that could be initialized
-    # with three parameters.
-    # elif issubclass(policy, RestrictingNodeTransformer):
-    else:
+    elif issubclass(policy, RestrictingNodeTransformer):
         c_ast = None
+        allowed_source_types = [str]
+        if IS_PY2:
+            allowed_source_types.append(unicode)
+        if not issubclass(type(source), tuple(allowed_source_types)):
+            raise TypeError('Not allowed source type: '
+                            '"{0.__class__.__name__}".'.format(source))
         try:
             c_ast = ast.parse(source, filename, mode)
         except (TypeError, ValueError) as e:
@@ -141,7 +144,6 @@ def compile_restricted(
     policy ... `ast.NodeTransformer` class defining the restrictions.
 
     """
-    byte_code, errors, warnings, used_names = None, None, None, None
     if mode in ['exec', 'eval', 'single', 'function']:
         result = _compile_restricted_mode(
             source,
@@ -157,6 +159,6 @@ def compile_restricted(
             warning,
             SyntaxWarning
         )
-    if errors:
+    if result.errors:
         raise SyntaxError(result.errors)
     return result.code

src/RestrictedPython/transformer.py

@@ -487,12 +487,14 @@ def generic_visit(self, node):
         """
         import warnings
         warnings.warn(
-            '{o.__class__.__name__} statement is not known to RestrictedPython'.format(node),
+            '{o.__class__.__name__}'
+            ' statement is not known to RestrictedPython'.format(node),
             SyntaxWarning
         )
         self.warn(
             node,
-            '{o.__class__.__name__} statement is not known to RestrictedPython'.format(node)
+            '{o.__class__.__name__}'
+            ' statement is not known to RestrictedPython'.format(node)
         )
         self.not_allowed(node)
 

tests/test_compile.py

@@ -1,11 +1,17 @@
 from . import compile
+from RestrictedPython import compile_restricted
 from RestrictedPython import CompileResult
 from RestrictedPython._compat import IS_PY2
 
 import pytest
 import RestrictedPython.compile
 
 
+def test_compile__compile_restricted_invalid_code_input():
+    with pytest.raises(TypeError):
+        compile_restricted(object(), '<string>', 'eval')
+
+
 @pytest.mark.parametrize(*compile)
 def test_compile__compile_restricted_exec__1(compile):
     """It returns a CompileResult on success."""

tox.ini

@@ -15,12 +15,14 @@ skip_missing_interpreters = False
 
 [testenv]
 usedevelop = True
+extras =
+    develop
+    test
 commands =
     py.test --cov=src --cov-report=xml {posargs}
 setenv =
   COVERAGE_FILE=.coverage.{envname}
 deps =
-    .[test,develop]
     pytest
     pytest-cov
     pytest-remove-stale-bytecode