Check class names.

zopefoundation · Nov 9, 2016 · f41bf71 · f41bf71
1 parent 59e3258
commit f41bf71
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/RestrictedPython/transformer.py b/src/RestrictedPython/transformer.py
@@ -1466,9 +1466,9 @@ def visit_Nonlocal(self, node):
         return self.generic_visit(node)
 
     def visit_ClassDef(self, node):
-        """
+        """Checks the name of classes."""
 
-        """
+        self.check_name(node, node.name)
         return self.generic_visit(node)
 
     def visit_Module(self, node):

diff --git a/tests/test_transformer.py b/tests/test_transformer.py
@@ -792,3 +792,15 @@ def test_transformer__RestrictingNodeTransformer__visit_Import(compile):
     code, errors = compile('from a import _m as n')[:2]
     assert code == None
     assert errors[0] == (errmsg % '_m')
+
+
+@pytest.mark.parametrize(*compile)
+def test_transformer__RestrictingNodeTransformer__visit_ClassDef(compile):
+    code, errors = compile('class Good: pass')[:2]
+    assert code is not None
+    assert errors == ()
+
+    code, errors = compile('class _bad: pass')[:2]
+    assert code is None
+    assert errors[0] == 'Line 1: "_bad" is an invalid variable name ' \
+                        'because it starts with "_"'