Several checks for __builtins__ and builtins. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtins are a dangourse element in RestrictedPython, as they contain the whole Programming Environment with all modules and conroll access to them. Should be forbidden to access.
icemac
approved these changes
Oct 2, 2018
tests/test_imports.py
Outdated
| ) | ||
| @pytest.mark.parametrize(*c_exec) | ||
| def test_import_py2_as_builtins(c_exec): | ||
| """It should not be allowed to access global builtins in Python3.""" |
tests/test_imports.py
Outdated
| ) | ||
| @pytest.mark.parametrize(*c_exec) | ||
| def test_import_py2_builtins(c_exec): | ||
| """It should not be allowed to access global builtins in Python3.""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtins is a dangerous element in RestrictedPython, as it contains the whole Programming Environment with all modules and control access to them.
Should be forbidden to access.
Fixes #115