Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change behaviour of same_type function #135

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Conversation

loechel
Copy link
Member

@loechel loechel commented Oct 2, 2018

change behaviour of same_type function in RestrictedPython.Utilities so that it returns a bool instaed of 0 or 1.

Fixes #122

…so that it returns a bool instaed of 0 or 1.

This is a proposal for #122
@loechel loechel self-assigned this Oct 2, 2018
@loechel loechel requested a review from icemac October 2, 2018 17:59
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac added this to To do in RestrictedPython 4.0 via automation Oct 3, 2018
@icemac icemac added this to In progress in Zope 4 final release via automation Oct 3, 2018
@icemac icemac moved this from To do to In progress in RestrictedPython 4.0 Oct 3, 2018
@icemac icemac moved this from In progress to Reviewer approved in Zope 4 final release Oct 3, 2018
@loechel loechel merged commit 673a45f into master Oct 3, 2018
RestrictedPython 4.0 automation moved this from In progress to Done Oct 3, 2018
Zope 4 final release automation moved this from Reviewer approved to Done Oct 3, 2018
@loechel loechel deleted the same_type_return_bool branch October 3, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants