Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning about print statement. #161

Merged

Conversation

dhavlik
Copy link

@dhavlik dhavlik commented May 8, 2019

Its useless because a) its wrong, since its also displayed when you already use the print function and b) the actual error message when using py3 is far more precise and useful and finally c) we don't use deprecation warnings elsewhere

Fixes #155.

Daniel Havlik added 2 commits May 8, 2019 11:34
…less because a) its wrong, since its also displayed when you already use the print function and b) the actual error message when using py3 is far more precise and useful and finally c) we don't use deprecation warnings elsewhere
@dhavlik dhavlik requested a review from icemac May 8, 2019 11:47
@icemac icemac changed the title fixes #155, remove deprecation warning about print statement. Remove deprecation warning about print statement. May 8, 2019
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@icemac icemac added this to To do in RestrictedPython 4.0 via automation May 8, 2019
@icemac icemac added this to In progress in Zope 4 final release via automation May 8, 2019
@icemac icemac moved this from To do to In progress in RestrictedPython 4.0 May 8, 2019
@dhavlik dhavlik merged commit 1a4876b into master May 8, 2019
RestrictedPython 4.0 automation moved this from In progress to Done May 8, 2019
Zope 4 final release automation moved this from In progress to Done May 8, 2019
@dhavlik dhavlik deleted the re-155-remove-deprecation-warning-for-print-statement branch May 8, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Broken warning about "print"
2 participants