Fix problems on CI, conventions are not checked. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CI (Travis and Appveyor) the lint Checks does not run and therefore the master is dirty.
loechel
changed the title
loechel
added a commit
that referenced
this pull request
Sep 1, 2019
|
I did it the other way round: Merging #174 first and updating this PR to the new master to get it green. |
icemac
approved these changes
Sep 2, 2019
tox.ini
Outdated
| @@ -48,10 +48,9 @@ commands = | |||
| coverage combine | |||
| coverage html | |||
| coverage xml | |||
| coverage report --skip-covered --show-missing --fail-under=100.0 | |||
| coverage report --show-missing --fail-under=100.0 | |||
There was a problem hiding this comment.
I do not understand why you want to see a long list of 100 % covered modules as 100 % coverage is required. If a module drops below it will be shown as the only one with too low coverage no need to search for the module in a long output.
Suggested change
| coverage report --show-missing --fail-under=100.0 | |
| coverage report --skip-covered --show-missing --fail-under=100.0 |
There was a problem hiding this comment.
well I do understand that you like to only show the files where actual coverage is missing.
I have reactivate that setting but in the setup.cfg file
icemac
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI (Travis and Appveyor) the lint Checks does not run and therefore the master is dirty.
This Pull-Request is a base to fix the dirty Master and ensure that the Linting ( Convention Checks ) are run on each push to github. This fixes #172
By the way therefor this Pull Request should be red on CI to show that the errors now show up.
As a second step then a fix to the dirty master is necessary to fix the lining errors.