Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting an attribute has to be guarded, too. #61

Merged
merged 1 commit into from May 5, 2017
Merged

Deleting an attribute has to be guarded, too. #61

merged 1 commit into from May 5, 2017

Conversation

icemac
Copy link
Member

@icemac icemac commented May 5, 2017

No description provided.

@icemac icemac requested review from stephan-hof and loechel May 5, 2017 09:31
loechel
loechel approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@loechel loechel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemac icemac merged commit 7870aa2 into Python3_update May 5, 2017
@icemac icemac deleted the fix-del-attr branch May 5, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loechel loechel loechel approved these changes

@stephan-hof stephan-hof Awaiting requested review from stephan-hof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemac @loechel