support "delay" and "encoding" for <logfile> #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- neither parameter is supported for STDOUT, STDERR (errors are reported at the time the handler is constructed) - closes #49
jamadden
reviewed
Dec 4, 2018
| if self.delay: | ||
| self.stream = None | ||
| else: | ||
| self.stream = open(self.baseFilename, self.mode, self.encoding) |
There was a problem hiding this comment.
I don't think the call to open is correct here for either Python 2 or 3. On Python 2 the signature is open(name[, mode[, buffering]]). On Python 3 the signature is open(file, mode='r', buffering=-1, encoding=None, errors=None, newline=None, closefd=True, opener=None). So both versions are going to interpret self.encoding as buffering.
To get an open that supports encoding= on Python 2, you can use io.open
I believe this code is not tested by Travis and is excluded from the coverage report
There was a problem hiding this comment.
You're right! Fixed in 63465a8.
logging.FileHandler._open already deals with py2/py3 compatiblity, and handles all the parameters to open a file in a consistent way; no need to reimplement in just one case
jamadden
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neither parameter is supported for STDOUT, STDERR
(errors are reported at the time the handler is
constructed)
closes Support delay parameter for file-based handlers #49