Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #97

Merged
merged 5 commits into from
May 18, 2024
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented May 14, 2024

Dependencies:

Fixes #96

@dataflake
Copy link
Member

zope.interface release 6.4 is now published.

@icemac
Copy link
Member Author

icemac commented May 16, 2024

I do not plan to work on fixing this issue, as I have no clue what is going wrong here.

@d-maurer
Copy link
Contributor

d-maurer commented May 17, 2024 via email

Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM.

@d-maurer, I noticed that you removed a changelog entry. Shouldn't we have an entry , - Added support for Python 3.13, as well as adding the corresponding Trove classifier to setup.py?

@tseaver tseaver marked this pull request as ready for review May 18, 2024 13:41
@tseaver tseaver merged commit 9d27e16 into master May 18, 2024
17 checks passed
@tseaver tseaver deleted the config-with-pure-python-template-e7051a16 branch May 18, 2024 13:42
@musicinmybrain
Copy link
Contributor

Thanks! This fix works for me.

@d-maurer
Copy link
Contributor

d-maurer commented May 18, 2024 via email

@tseaver
Copy link
Member

tseaver commented May 18, 2024

@d-maurer Oops, I saw that we had finished all the issues @icemac noted, and went ahead and added them before merging. Sorry for being too quick on the trigger.

@icemac
Copy link
Member Author

icemac commented May 22, 2024

Thank you for the work to fix this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure in test_filehandler_reopen_thread_safety on Python 3.13
5 participants