Merge pull request #28 from zopefoundation/27-fix_file_leak

Close opened-file leak in blob cache size check.
zopefoundation · Jun 16, 2016 · a7a5fab · a7a5fab
2 parents 7a1a380 + 2f69196
commit a7a5fab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ZEO/ClientStorage.py b/src/ZEO/ClientStorage.py
@@ -1667,8 +1667,8 @@ def _check_blob_cache_size(blob_dir, target):
 
     logger = logging.getLogger(__name__+'.check_blob_cache')
 
-    layout = open(os.path.join(blob_dir, ZODB.blob.LAYOUT_MARKER)
-                  ).read().strip()
+    with open(os.path.join(blob_dir, ZODB.blob.LAYOUT_MARKER)) as layout_file:
+        layout = layout_file.read().strip()
     if not layout == 'zeocache':
         logger.critical("Invalid blob directory layout %s", layout)
         raise ValueError("Invalid blob directory layout", layout)