Skip to content

Commit

Permalink
Cleaned up check_checkCurrentSerialInTransaction
Browse files Browse the repository at this point in the history
- Use assertEqual rather than assertTrue for better error messages.

- Fixed a typo that caused an assertion to be missed.
  • Loading branch information
Jim Fulton committed Nov 13, 2016
1 parent 807ba63 commit 327d726
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ZODB/tests/BasicStorage.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ def check_checkCurrentSerialInTransaction(self):
self._storage.checkCurrentSerialInTransaction(oid, tid, t)
self._storage.tpc_vote(t)
except POSException.ReadConflictError as v:
self.assertTrue(v.oid) == oid
self.assertTrue(v.serials == (tid2, tid))
self.assertEqual(v.oid, oid)
self.assertEqual(v.serials, (tid2, tid))
else:
if 0: self.assertTrue(False, "No conflict error")

Expand Down

0 comments on commit 327d726

Please sign in to comment.