Don't manipulate Connection state after it has been returned to the p…

…ool.

Doing so leads to race conditions.

In particular, there can be an AttributeError.

See zodb/zodbshootout#26 for details.

(cherry picked from commit f8cf23e)

CHANGES.rst

@@ -7,6 +7,10 @@
 
 - ``persistent`` is no longer required at setup time.
   See `issue 119 <https://github.com/zopefoundation/ZODB/issues/119>`_.
+- ``Connection.close`` and ``Connection.open`` no longer race on
+  ``self.transaction_manager``, which could lead to
+  ``AttributeError``. This was a bug introduced in 5.0.1. See `issue
+  142 <https://github.com/zopefoundation/ZODB/pull/143>`_.
 
 4.4.4 (2016-11-27)
 ==================

src/ZODB/Connection.py

@@ -315,6 +315,14 @@ def close(self, primary=True):
         if self._mvcc_storage:
             self._storage.sync(force=False)
 
+
+        am = self._db._activity_monitor
+        if am is not None:
+            am.closedConnection(self)
+
+        # Drop transaction manager to release resources and help prevent errors
+        self.transaction_manager = None
+
         if primary:
             for connection in self.connections.values():
                 if connection is not self:
@@ -331,12 +339,9 @@ def close(self, primary=True):
         else:
             self.opened = None
 
-        am = self._db._activity_monitor
-        if am is not None:
-            am.closedConnection(self)
+        # We may have been reused by another thread at this point so
+        # we can't manipulate or check the state of `self` any more.
 
-        # Drop transaction manager to release resources and help prevent errors
-        self.transaction_manager = None
 
     def db(self):
         """Returns a handle to the database this connection belongs to."""