repozo: do not close file in concat function

But let the caller opening the file closing it
zopefoundation · Nov 23, 2018 · d6bcc5a · d6bcc5a
1 parent a835827
commit d6bcc5a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/ZODB/scripts/repozo.py b/src/ZODB/scripts/repozo.py
@@ -360,8 +360,6 @@ def func(data):
             ifp = open(f, 'rb')
         bytesread += dofile(func, ifp)
         ifp.close()
-    if ofp:
-        ofp.close()
     return bytesread, sum.hexdigest()
 
 

diff --git a/src/ZODB/scripts/tests/test_repozo.py b/src/ZODB/scripts/tests/test_repozo.py
@@ -414,7 +414,7 @@ def close(self):
         ofp = Faux()
         bytes, sum = self._callFUT(files, ofp)
         self.assertEqual(ofp._written, [x.encode() for x in 'ABC'])
-        self.assertTrue(ofp._closed)
+        self.assertFalse(ofp._closed)
 
 _marker = object()
 class Test_gen_filename(OptionsTestBase, unittest.TestCase):