Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB root-object creation should use a connection #84

Closed
jimfulton opened this issue Jul 7, 2016 · 0 comments · Fixed by #95
Closed

DB root-object creation should use a connection #84

jimfulton opened this issue Jul 7, 2016 · 0 comments · Fixed by #95

Comments

@jimfulton
Copy link
Member

When a DB is created, it tried to make sure that the root object exists. It doesn't use a connection to do this, but implements the transaction logic itself. It hasn't kept up, however with recent changes in the MVCC implementation, as I discovered in some failing ZEO tests.

DB logic should be updated to use a connection to do the transaction processing, even if changes are needed to Connection to deal with object 0 not being present.

jimfulton pushed a commit to zopefoundation/ZEO that referenced this issue Jul 7, 2016
jimfulton pushed a commit that referenced this issue Jul 23, 2016
This fixes #84.

Also:

- Added missing transaction ``begin`` call in the DB ``transaction()``
  context manager.

- Added the ability to add a transaction note whan calling
  ``transaction()``.  This is useful (as would be the ability to pass
  in other transaction meta data, but this was needed by (and this
  tested) to make an existing test pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant