Fixed: ZODB.Connection.TransactionMetaData didn't custom data #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storage that some storages rely on.
jamadden
requested changes
Nov 18, 2016
| @@ -2,6 +2,9 @@ | |||
| Change History | |||
| ================ | |||
|
|
|||
| - Fixed: ``ZODB.Connection.TransactionMetaData`` didn't custom data | |||
| try: | ||
| return data[id(ob)] | ||
| except KeyError: | ||
| raise KeyError(ob) |
There was a problem hiding this comment.
Is this simpler and equivalent (fewer lines of code to cover)?
try:
return self._data[id(ob)]
except (AttributeError, KeyError):
raise KeyError(ob)Not that it's a big deal. If you prefer the more explicit version that's fine by me.
There was a problem hiding this comment.
Sure. This code was copied verbatim from transaction.
added 2 commits
November 18, 2016 12:14
jamadden
approved these changes
Nov 18, 2016
jimfulton
deleted the
data-for-TransactionMetaData-and-TransactionRecord
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage that some storages rely on.