Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent resolution order with zope.interface v5. #310

Merged
merged 4 commits into from Jun 2, 2020
Merged

Fix inconsistent resolution order with zope.interface v5. #310

merged 4 commits into from Jun 2, 2020

Conversation

janjaapdriessen
Copy link
Member

No description provided.

jamadden
jamadden reviewed May 20, 2020
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this!

All Python 3 builds are failing because they are building the sphinx docs, and j1m.autointerface is using Sphinx internals that have changed. I would suggest moving to repoze.sphinx.autointerface. Maybe that can happen in a separate PR and then this be rebased once that's merged?

tox.ini Show resolved Hide resolved
src/ZODB/blob.py Outdated Show resolved Hide resolved
src/ZODB/FileStorage/FileStorage.py Show resolved Hide resolved
@janjaapdriessen
Copy link
Member Author

All Python 3 builds are failing because they are building the sphinx docs, and j1m.autointerface is using Sphinx internals that have changed. I would suggest moving to repoze.sphinx.autointerface. Maybe that can happen in a separate PR and then this be rebased once that's merged?

I did spelunking and found out that j1m.autointerface was a temporary fork of sphinxcontrib.zopeext. I updated the dependencies in 463fc5a and am waiting to see whether Travis will like these changes.

@jmuchemb jmuchemb mentioned this pull request Jun 2, 2020
Closed
jamadden
jamadden approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmuchemb jmuchemb merged commit 5ce50c3 into master Jun 2, 2020
@mgedmin mgedmin deleted the zope-interface-fix-inconsistent-iro branch June 2, 2020 16:40
@jmuchemb jmuchemb mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamadden jamadden jamadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janjaapdriessen @jamadden @jmuchemb