Fix racetest problems
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treat failure for a test thread to finish as a test failure
|
@d-maurer I am currently fixing the GHA configuration-related errors and deprecation warnings on |
|
If you merge in 9ffc59e you should get the py35/py36 tests back and get rid of all the deprecation warnings. |
|
The failing test runs (Python 3.5 and 3.6) have missing Python installations for those outdated versions as cause. |
|
Jens Vagelpohl wrote at 2023-2-3 03:26 -0800:
If you merge in 9ffc59e you should get the py35/py36 tests back and get rid of all the deprecation warnings.
Thank you for your help!
|
navytux
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems with the
racetests observed during work on "zopefoundation/ZEO#225".It uses daemon (rather than normal) threads to avoid deadlock on shutdown when one of the test threads has not finished. It treats the failure for a test thread to finish as a test failure.