Per @jimfulton, handle_all_serials shouldn't be sniffing in ZODB5 #87
Conversation
|
Turns out that at least the tests pass sequences of non-bytes to this method on Python 3 (probably str?), so I had to remove that assert. |
| @@ -194,10 +178,7 @@ def _dostore(self, oid=None, revid=None, data=None, | |||
| r1 = self._storage.store(oid, revid, data, '', t) | |||
There was a problem hiding this comment.
We don't use r1 and r2, so why assign them?
There was a problem hiding this comment.
I was trying to make the diff as minimal as possible. I can clean that up.
|
Gutting the methods is confusing. Let's not leave this for a future code reader to stumble on. (It will probably be me and I just hurt myself for the last few minutes on this :) ). We should remove these functions and their call points, or just remove the calls in dostore, if that's what was hurting RelStorage. |
OK, I can remove the functions and their callers. That will involve touching three more files, but I think it's mostly copy-pasted code. |
|
Travis appears to be green with the removal. I say appears because github has been lagging a lot lately. |
So try that. This slightly simplifies _dostore.
There are lots of other callers still so I didn't remove the functions entirely (but I could try if desired).