Skip to content

Commit

Permalink
Disable ZCatalog performance test (#1137)
Browse files Browse the repository at this point in the history
* Disable a `ZCatalog` (more precisely `Products.PluginIndexes`) performance test which occasionally fails on GITHUB

* Make changes permanent

otherwise they are removed on the next run of `meta/config`.

---------

Co-authored-by: Michael Howitz <mh@gocept.com>
  • Loading branch information
d-maurer and Michael Howitz committed Jun 19, 2023
1 parent 10c1eb4 commit 1f2a5a6
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .meta.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ testenv-commands-pre = [
"{envbindir}/buildout -c {toxinidir}/buildout.cfg buildout:directory={envdir} buildout:develop={toxinidir} install alltests",
]
testenv-commands = [
"{envdir}/bin/alltests {posargs:-vc}",
"# the `layer` argument below suppresses a `ZCatalog` performance test",
"# which occasionally fails on GITHUB",
"{envdir}/bin/alltests --layer '!Products.PluginIndexes' {posargs:-vc}",
]
coverage-basepython = "python3.8"
coverage-command = "coverage run {envdir}/bin/alltests {posargs:-vc}"
Expand Down
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.8.4 (unreleased)
------------------

- Disable a ``ZCatalog`` (more precisly: ``Products.PluginIndexes``)
performance test which occasionally fails on GITHUB.
For details, see
`#1136 <https://github.com/zopefoundation/Zope/issues/1136>`_.

- Update to newest compatible versions of dependencies.


Expand Down
4 changes: 3 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ deps =
commands_pre =
{envbindir}/buildout -c {toxinidir}/buildout.cfg buildout:directory={envdir} buildout:develop={toxinidir} install alltests
commands =
{envdir}/bin/alltests {posargs:-vc}
# the `layer` argument below suppresses a `ZCatalog` performance test
# which occasionally fails on GITHUB
{envdir}/bin/alltests --layer '!Products.PluginIndexes' {posargs:-vc}

[testenv:pre-commit]
basepython = python3
Expand Down

0 comments on commit 1f2a5a6

Please sign in to comment.