Add change log entry and test.

zopefoundation · May 2, 2019 · 334879e · 334879e
1 parent 66a4009
commit 334879e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -33,6 +33,10 @@ Fixes
 
 - prevent ``mkwsgiinstance`` from blowing up parsing ``buildout.cfg``
 
+- Fix ``ZPublisher.HTTPResponse.HTTPBaseResponse.isHTML`` for binary data on
+  Python 3.
+  (`#577 <https://github.com/zopefoundation/Zope/pull/577>`_)
+
 Features
 ++++++++
 

diff --git a/src/ZPublisher/tests/testHTTPResponse.py b/src/ZPublisher/tests/testHTTPResponse.py
@@ -1346,3 +1346,7 @@ def test_exception_500_text(self):
             self.assertTrue(expected in bytes(body))
             self.assertEqual(response.status, 500)
             self.assertEqual(response.errmsg, 'Internal Server Error')
+
+    def test_isHTML_not_decodable_bytes(self):
+        response = self._makeOne()
+        self.assertFalse(response.isHTML(u'bïñårÿ'.encode('latin1')))