Skip to content

Commit

Permalink
- downgrade z3c.checkversions which requires pinning setuptools
Browse files Browse the repository at this point in the history
Pinning setuptools causes nothing but trouble in several other projects
that I maintain that use the Zope version pins. The version pin was
required because z3c.checkversions 2.0 introduced its own setuptools version
pin, so this PR downgrades it to version 1.2 again.
  • Loading branch information
dataflake committed May 25, 2023
1 parent fcf8c4a commit 5128b94
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ pycparser==2.21
python-gettext==5.0
pytz==2023.3
roman==4.0
setuptools==65.7.0
six==1.16.0
soupsieve==2.4.1
transaction==3.1.0
Expand Down
1 change: 0 additions & 1 deletion requirements-full.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ pycparser==2.21
python-gettext==5.0
pytz==2023.3
roman==4.0
setuptools==65.7.0
six==1.16.0
soupsieve==2.4.1
transaction==3.1.0
Expand Down
1 change: 0 additions & 1 deletion versions-prod.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ python-gettext = 5.0
pytz = 2023.3
six = 1.16.0
roman = 4.0
setuptools = 65.7.0
soupsieve = 2.4.1
transaction = 3.1.0
waitress = 2.1.2
Expand Down
5 changes: 4 additions & 1 deletion versions.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ sphinxcontrib-qthelp = 1.0.3
sphinxcontrib-serializinghtml = 1.1.5
tempstorage = 6.0
urllib3 = 2.0.2
z3c.checkversions = 2.0
# z3c.checkversions 2.0 pins setuptools, which then requires adding a version
# pin for setuptools in Zope, which in turn caused issues in many projects I
# have seen that rely on the Zope version pins.
z3c.checkversions = 1.2
zc.recipe.testrunner = 3.0
zope.testrunner = 6.0

0 comments on commit 5128b94

Please sign in to comment.