Skip to content

Commit

Permalink
- add version pin for SecretStorage
Browse files Browse the repository at this point in the history
  • Loading branch information
dataflake committed Nov 29, 2019
1 parent cc17001 commit 6a9d18d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Products.BTreeFolder2==4.2
Products.ZCatalog==5.0.1
Record==3.5
RestrictedPython==5.0
SecretStorage==3.1.1
WSGIProxy2==0.4.6
WebOb==1.8.5
WebTest==2.0.33
Expand Down
1 change: 1 addition & 0 deletions requirements-full.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Products.BTreeFolder2==4.2
Products.ZCatalog==5.0.1
Record==3.5
RestrictedPython==5.0
SecretStorage==3.1.1

This comment has been minimized.

Copy link
@icemac

icemac Dec 6, 2019

Member

@dataflake This means this package is always installed when installing using requirements-full.txt (maybe we should deprecate or remove this installation variant as one pip variant (using constraints.txt) should be enough.)

This comment has been minimized.

Copy link
@dataflake

dataflake Dec 6, 2019

Author Member

I wouldn't mind removing that installation variant, but the installation document already has a clear warning that it may install packages you don't need. Isn't that "good enough"?

This comment has been minimized.

Copy link
@icemac

icemac Dec 9, 2019

Member

@dataflake Okay, I consider it "good enough", at least for now.

WSGIProxy2==0.4.6
WebOb==1.8.5
WebTest==2.0.33
Expand Down
1 change: 1 addition & 0 deletions versions-prod.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Products.BTreeFolder2 = 4.2
Products.ZCatalog = 5.0.1
Record = 3.5
RestrictedPython = 5.0
SecretStorage = 3.1.1
WSGIProxy2 = 0.4.6
WebOb = 1.8.5
WebTest = 2.0.33
Expand Down

0 comments on commit 6a9d18d

Please sign in to comment.