Avoid raising Redirect to avoid aborting the transaction.

This reverts further parts of c424137.
zopefoundation · Sep 14, 2017 · 993da0d · 993da0d
1 parent 05ec0d6
commit 993da0d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/App/FactoryDispatcher.py b/src/App/FactoryDispatcher.py
@@ -161,6 +161,7 @@ def __getattr__(self, name):
     def manage_main(trueself, self, REQUEST, update_menu=0):
         """Implement a contents view by redirecting to the true view
         """
-        raise Redirect(self.DestinationURL() + '/manage_main')
+        REQUEST.RESPONSE.redirect(self.DestinationURL() + '/manage_main')
+
 
 InitializeClass(FactoryDispatcher)
diff --git a/src/App/Management.py b/src/App/Management.py
@@ -80,7 +80,7 @@ def manage_workspace(self, REQUEST):
                 'You are not authorized to view this object.')
 
         if m.find('/'):
-            raise Redirect("%s/%s" % (REQUEST['URL1'], m))
+            return REQUEST.RESPONSE.redirect("%s/%s" % (REQUEST['URL1'], m))
 
         return getattr(self, m)(self, REQUEST)
 

diff --git a/src/OFS/PropertySheets.py b/src/OFS/PropertySheets.py
@@ -325,9 +325,9 @@ def _propdict(self):
     manage = DTMLFile('dtml/properties', globals())
 
     security.declareProtected(manage_properties, 'manage_propertiesForm')
-    def manage_propertiesForm(self, URL1):
+    def manage_propertiesForm(self, URL1, RESPONSE):
         " "
-        raise Redirect(URL1 + '/manage')
+        RESPONSE.redirect(URL1 + '/manage')
 
     security.declareProtected(manage_properties, 'manage_addProperty')
     def manage_addProperty(self, id, value, type, REQUEST=None):