- add more flake8 test exclusions where needed

zopefoundation · Mar 25, 2019 · 9a70218 · 9a70218
1 parent 0693e5a
commit 9a70218
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 24 deletions.
diff --git a/src/Products/Five/tests/testing/__init__.py b/src/Products/Five/tests/testing/__init__.py
@@ -14,7 +14,7 @@
 """Test helpers
 """
 
-from Products.Five.tests.testing.folder import FiveTraversableFolder  # NOQA
-from Products.Five.tests.testing.folder import NoVerifyPasteFolder
-from Products.Five.tests.testing.folder import manage_addFiveTraversableFolder
-from Products.Five.tests.testing.folder import manage_addNoVerifyPasteFolder
+from .folder import FiveTraversableFolder  # NOQA: F401
+from .folder import NoVerifyPasteFolder  # NOQA: F401
+from .folder import manage_addFiveTraversableFolder  # NOQA: F401
+from .folder import manage_addNoVerifyPasteFolder  # NOQA: F401
diff --git a/src/Products/PageTemplates/PageTemplateFile.py b/src/Products/PageTemplates/PageTemplateFile.py
@@ -76,7 +76,7 @@ class PageTemplateFile(SimpleItem, Script, PageTemplate, Traversable):
     _default_bindings = {'name_subpath': 'traverse_subpath'}
 
     security = ClassSecurityInfo()
-    security.declareProtected(
+    security.declareProtected(  # NOQA: D001
         'View management screens', 'read', 'document_src')
 
     def __init__(

diff --git a/src/ZTUtils/__init__.py b/src/ZTUtils/__init__.py
@@ -13,27 +13,23 @@
 """Package of template utility classes and functions.
 """
 from AccessControl.SecurityInfo import ModuleSecurityInfo
-from ZTUtils.Zope import LazyFilter
-from ZTUtils.Zope import SimpleTreeMaker
-from ZTUtils.Zope import TreeMaker
-from ZTUtils.Zope import make_hidden_input
-from ZTUtils.Zope import make_query
-from ZTUtils.Zope import url_query
-
-from .Tree import a2b  # NOQA
-from .Tree import b2a
-from .Tree import decodeExpansion
-from .Tree import encodeExpansion
-
-
-from ZTUtils.Zope import Batch  # NOQA; NOQA
 
+from .Tree import a2b  # NOQA: F401
+from .Tree import b2a  # NOQA: F401
+from .Tree import decodeExpansion  # NOQA: F401
+from .Tree import encodeExpansion  # NOQA: F401
+from .Zope import Batch  # NOQA: F401
+from .Zope import LazyFilter  # NOQA: F401
+from .Zope import SimpleTreeMaker  # NOQA: F401
+from .Zope import TreeMaker  # NOQA: F401
+from .Zope import make_hidden_input  # NOQA: F401
+from .Zope import make_query  # NOQA: F401
+from .Zope import url_query  # NOQA: F401
 
 
 security = ModuleSecurityInfo('ZTUtils')
 
-security.declarePublic('encodeExpansion', 'decodeExpansion', 'a2b', 'b2a')
-
-security.declarePublic('Batch', 'TreeMaker', 'SimpleTreeMaker', 'LazyFilter')
-
-security.declarePublic('url_query', 'make_query', 'make_hidden_input')
+for name in ('encodeExpansion', 'decodeExpansion', 'a2b', 'b2a',
+             'Batch', 'TreeMaker', 'SimpleTreeMaker', 'LazyFilter'
+             'url_query', 'make_query', 'make_hidden_input'):
+    security.declarePublic(name)  # NOQA: D001